Eric Callahan

Results 245 comments of Eric Callahan

I noticed this PR in my inbox, so I thought it would be prudent to bring up that GitHub has [deprecated the old actions](https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). Presumably they will set a concrete...

I think the primary issue is that the TMC drivers don't consistently report temperature, thus they may not be a good candidate for a complete `temperature_sensor` implementation. I touched on...

I believe I had previously approved these changes in another pull request, however as I recall there were merge conflicts due to the SDIO addition. I'll take another look at...

Thanks. I had a couple of minor observations, however overall it looks good. > Yes I had a PR before that broke because of refactoring of the IO stuff, so...

I left a couple of comments in a review above that haven't been addressed. Specifically, now that SDIO is supported on the F4 we should avoid using Software SPI on...

It should be possible to clear the contents of the directory first, the functionality to list directory contents and remove items is in there. Such functionality would likely require adding...

I think it would make most sense to report `mcu_startup_time` with `mcu_uptime` in the `toolhead` object. The toolhead may not use it, however grouping them together at least makes documentation...

> That would fire the event (in this case even when the sensor is disabled(reason being, a lot of people prefer to keep the sensors disabled cause for some odd...

I have successfully tested both with and without the new `-s` option on an SKR 1.3 and Flyboard Mini. Everything is working as expected, so I have changed this PR's...

Interesting. I think the chances that we would unintentionally write `CRP3` are extremely low, but I see the utility in making it impossible. If its decided that we need to...