Eric Callahan

Results 245 comments of Eric Callahan

Direct support in the slicer would certainly be ideal.

Thanks. One thing we would need to be sure of is that these changes don't break compatibility with previous versions of WLED. Since this PR includes multiple, unrelated changes to...

Moonraker supports more robust authentication using JSON Web Tokens, however your front end needs to support it. Fluidd does, I do not believe that Mainsail does. Basic Auth is something...

The configuration should be similar, just a difference in the address the proxy is listening on. There may be additional changes required for an advanced configuration rewriting multiple services on...

Indeed, it is my opinion. If you believe that Basic Auth is sufficient for your needs then it is certainly your decision to use it.

Thanks. I'm open to discussing generic sensor support, however the `aioesphomeapi` dependency will create an issue. It depends on `noiseprotocol`, which depends on `cryptography`. Unfortunately the Rust bindings in `cryptography`...

Thanks, the configuration documentation provided me with a more generalized idea of what you are looking to accomplish. I think this module adds value, and I have added some review...

It is close, just a couple of minor issues and the "notification bundling". Additionally the APIs and websocket notification will need documentation, then it will be ready to merge.

Other than the missing sensor event name the changes to the source look good. You need to rebase your branch against master to resolve the merge conflicts with `api_changes.md`, frankly...

Thanks. I found some issues with the docs, and apparently I missed a problem with the `measurements` request in my last review. I also proposed refactoring the name of `/server/sensors/sensor`...