Arkadi Koifman

Results 133 comments of Arkadi Koifman

@AhmedKarray005 If we would have "show password" it is not relevant. @kabir0x23 what do you think?

@AhmedKarray005 You don't need to clear input if we have show password so the user could change typo and so on. Let's wait @kabir0x23 to hear his opinion

@AhmedKarray005 I changed the title, to add show password button, would you like to handle it? Don't remove the incorrect password on wrong submission.

@AhmedKarray005 I think it is better to add some margin bottom to emphasize that this related to the password input box. Beside it, looks great thanks. Could you open a...

@AhmedKarray005 yes, even though, I am not sure of the icons. I think when you see the password the eye should be without cross and the opposite.

@kabir0x23 I need to look for similar examples. Do you know which way is correct? Of the icons?

I found example :) I don't know haha very hard question, who is right https://github.com/thecyberworld/TheCyberHUB/assets/76536506/7ce31203-698e-48a2-be4b-8a86c281b095

@kabir0x23 ok great, @AhmedKarray005 yes please open the pr

@AhmedKarray005 is it ok the someone else will work on it? I saw that someone opened new pr ![image](https://github.com/thecyberworld/TheCyberHUB/assets/76536506/5f39d6f7-eee0-4ebb-b927-3b2ce7fa7048)

> > Hey, not sure about the style guides for this project but I would start by removing all the comments from the CSS files. > > hi we use...