TheCyberHUB icon indicating copy to clipboard operation
TheCyberHUB copied to clipboard

fest: Team Page Base

Open AhmedKarray005 opened this issue 9 months ago • 10 comments

Screenshots

https://github.com/thecyberworld/TheCyberHUB/assets/104280658/1638a85e-eee3-4aef-b353-8e3957741c1d

Code of Conduct

  • [x] By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

  • [x] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] All new and existing tests passed.
  • [x] This PR does not contain plagiarized content.
  • [x] The title of my pull request is a short description of the requested changes.

You can also join our Discord community. Feel free to check out other cool repositories of the Thecyberworld. Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

AhmedKarray005 avatar May 09 '24 12:05 AhmedKarray005

Hey, not sure about the style guides for this project but I would start by removing all the comments from the CSS files.

hi we use styled components,. u can use that strucutre

kabir0x23 avatar May 11 '24 07:05 kabir0x23

Hey, not sure about the style guides for this project but I would start by removing all the comments from the CSS files.

hi we use styled components,. u can use that strucutre

@AhmedKarray005 Could you move the styles from css file and use styled-components?

ArkadiK94 avatar May 11 '24 16:05 ArkadiK94

@ArkadiK94 hello , can u maybe pull my work and open a new issue so that someone else can work on it?

AhmedKarray005 avatar May 11 '24 20:05 AhmedKarray005

@AhmedKarray005 ok, I will review the pr with the way you wrote inside css file and notify you if there are required changes to do before merging.

ArkadiK94 avatar May 11 '24 20:05 ArkadiK94

@AhmedKarray005 However, for your next pr, you should use styled components.

ArkadiK94 avatar May 11 '24 20:05 ArkadiK94

okay understood

AhmedKarray005 avatar May 11 '24 20:05 AhmedKarray005

@AhmedKarray005 did you install a new package? if so, please commit the package.json and package-lock.json files as well

image

ArkadiK94 avatar May 13 '24 16:05 ArkadiK94

@ArkadiK94 u can run this cmd npm install @fortawesome/react-fontawesome @fortawesome/fontawesome-svg-core @fortawesome/free-solid-svg-icons

AhmedKarray005 avatar May 15 '24 20:05 AhmedKarray005

@AhmedKarray005 I know how to fix it. The question, why didn't you commit the package.json file?

ArkadiK94 avatar May 15 '24 20:05 ArkadiK94

@ArkadiK94 u want me to commit them?

AhmedKarray005 avatar May 15 '24 23:05 AhmedKarray005

@AhmedKarray005 Yes, when you install new packages you have to commit the package.json and package-lock.json files as well.

ArkadiK94 avatar May 16 '24 03:05 ArkadiK94

@ArkadiK94 it is all good now

AhmedKarray005 avatar May 17 '24 11:05 AhmedKarray005

@AhmedKarray005 hi, we are using this https://react-icons.github.io/react-icons/ for icons

see if u can find those icons u want here

and u can replace with font awesome

kabir0x23 avatar May 18 '24 05:05 kabir0x23

@ArkadiK94 done , i updated them

AhmedKarray005 avatar May 19 '24 14:05 AhmedKarray005

@AhmedKarray005 Thanks, I will review the actual code and let you know :)

ArkadiK94 avatar May 19 '24 14:05 ArkadiK94