Daniil Polyakov

Results 41 comments of Daniil Polyakov

That's what the [Solidity docs](https://docs.soliditylang.org/en/v0.8.17/control-structures.html#checked-or-unchecked-arithmetic) say: > Prior to Solidity 0.8.0, arithmetic operations would always wrap in case of under- or overflow leading to widespread use of libraries that introduce...

Options we have: 1. Copy `Solidity` behaviour 2. Copy `Rust` behaviour 3. Remove `Multiply` at all

@appetrosyan , in my opinion, we should remove not only `Multiply` then. We should find a way to diferentiate between things we want to keep and things we want to...

@s8sato , no, Vasily means, that **downloaded** image works on M1, it always was working. But I'm still unable to build an image

@ales-tsurko , #2314 was merged, do you plan to work on this?

> Failing test Yes, it seems like we have contradictory requirements for transaction `Queue` in our tests: * `iroha_core::queue::tests::push_tx_signature_condition_failure` — requires to deny transaction if signature condition failied * `iroha_client::mod::integration::multisignature_transaction::multisignature_transactions_should_wait_for_all_signatures`...

@appetrosyan , alright, now the idea of `ok_or` seems more reasonable to me. However I stil have one question: there is `T` in trait definition and it's used as `ok_or`...

@appetrosyan and I have decided to ignore multisignature test for now. That's will be fixed in #2595

@appetrosyan , I've created an issue for `ValueIsError`: #2598