phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

[BUG] `client.get_spans_dataframe` is too slow

Open axiomofjoy opened this issue 1 year ago • 1 comments

From testing by @hamelsmu:

1. client.get_spans_dataframe 22s
2. downloading the SQL Lite DB and reading that into pandas: 1.6s
Here is a notebook comparing both https://gist.github.com/hamelsmu/2ce7636935b6d55c3852e25a445926c8

The remote compute on my local home network. But that shouldn’t matter because in the comparison i’m running scp to download the entire postgres db

axiomofjoy avatar Jul 30 '24 23:07 axiomofjoy

fwiw

RogerHYang avatar Jul 31 '24 00:07 RogerHYang

Hi, @axiomofjoy. I'm Dosu, and I'm helping the Arize Phoenix team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Performance discrepancy noted with client.get_spans_dataframe being slower than SQL Lite database operations.
  • A comparison notebook was provided by you for analysis.
  • Network speed was ruled out as a factor due to local network setup.
  • @RogerHYang referenced a specific line in the codebase that might be related.

Next Steps:

  • Could you confirm if this issue is still relevant with the latest version of the Arize Phoenix repository? If so, please comment to keep the discussion open.
  • If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

dosubot[bot] avatar Dec 15 '24 16:12 dosubot[bot]