phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Add Prometheus environment variable

Open axiomofjoy opened this issue 1 year ago • 6 comments

  • [x] add environment variable
  • [ ] add deprecation warning for command line argument
  • [ ] create ticket to remove command line argument in an upcoming sprint
  • [x] change the CMD in the Dockerfile
  • [ ] change the CMD in the Arize deployment of Phoenix
  • [ ] do a full-text search for --enable-prometheus to make sure we go everything

Originally posted by @mikeldking in https://github.com/Arize-ai/phoenix/pull/2708#discussion_r1543063546

axiomofjoy avatar Mar 28 '24 17:03 axiomofjoy

@mikeldking Can you clarify the details of this ticket? Do you want to remove the --enable-prometheus command line argument and have an environment variable instead?

axiomofjoy avatar Mar 28 '24 17:03 axiomofjoy

@mikeldking Can you clarify the details of this ticket? Do you want to remove the --enable-prometheus command line argument and have an environment variable instead?

I think this can be an opt-in feature via env-vars. Not every person that deploys phoenix needs prometheus metrics. To make the integration seamless we should just control it via environment variables rather than a launch command

mikeldking avatar Mar 29 '24 15:03 mikeldking

If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,

docker run -it -e "ENABLE_PROMETHEUS=TRUE" arizephoenix/phoenix:latest

axiomofjoy avatar Mar 29 '24 18:03 axiomofjoy

If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,

docker run -it -e "ENABLE_PROMETHEUS=TRUE" arizephoenix/phoenix:latest

Yes, it should be off by default

mikeldking avatar Apr 01 '24 17:04 mikeldking

Bumping back in priority.

mikeldking avatar Apr 26 '24 14:04 mikeldking

Fully remove --enable-prometheus command line argument.

axiomofjoy avatar Apr 26 '24 18:04 axiomofjoy