phoenix
phoenix copied to clipboard
Add Prometheus environment variable
- [x] add environment variable
- [ ] add deprecation warning for command line argument
- [ ] create ticket to remove command line argument in an upcoming sprint
- [x] change the
CMDin theDockerfile - [ ] change the
CMDin the Arize deployment of Phoenix - [ ] do a full-text search for
--enable-prometheusto make sure we go everything
Originally posted by @mikeldking in https://github.com/Arize-ai/phoenix/pull/2708#discussion_r1543063546
@mikeldking Can you clarify the details of this ticket? Do you want to remove the --enable-prometheus command line argument and have an environment variable instead?
@mikeldking Can you clarify the details of this ticket? Do you want to remove the
--enable-prometheuscommand line argument and have an environment variable instead?
I think this can be an opt-in feature via env-vars. Not every person that deploys phoenix needs prometheus metrics. To make the integration seamless we should just control it via environment variables rather than a launch command
If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,
docker run -it -e "ENABLE_PROMETHEUS=TRUE" arizephoenix/phoenix:latest
If I understand correctly, the user should be able to decide whether to run the container with Prometheus at runtime, e.g.,
docker run -it -e "ENABLE_PROMETHEUS=TRUE" arizephoenix/phoenix:latest
Yes, it should be off by default
Bumping back in priority.
Fully remove --enable-prometheus command line argument.