Ari Perkkiö

Results 126 comments of Ari Perkkiö

Looks like the same minimal reproduction gets stuck even with Node's `fetch` - should this be moved to `nodejs/node` issues instead? Or was Node using `undici` under the hood?

> Can you repro with just undici.request? Is this a fetch specific issue? `undici.request` does not cause this issue. Tested by running 100 rounds with `request()` successfully. The `fetch()` case...

> And now I can't reproduce it. 😢 This reproduction case is a bit flaky. You may need to add more parallel requests or increase the `const ROUNDS` to make...

> [...] docs explicitly say that it will "[s]top all JavaScript execution in the worker thread **as soon as possible**". There's no guarantee that it'll actually close the worker if...

Sure, the point was that it fails the CI: https://github.com/nodejs/undici/actions/runs/4551655590/jobs/8026203674#step:14:12832. CI should be used as reference instead of developer machines. It's much easier to reproduce the issue constantly that way.

> I wouldn't be surprised if createBrotliDecompress is causing issues I've been trying to reproduce this issue without `fetch` at all, using just `node:stream` and `node:zlib` with workers. So far...

> I wonder if this is the same of nodejs/node#47228 I don't think so. That issue mentions that it does not reproduce on Node 18 while this one does. Also...

Great work @tsctx and @jasnell (from https://github.com/nodejs/node/pull/51255, :wave:)! This issue seems to be fixed. I ran these tests using `[email protected]` and following Node versions: - ❌ `v18.19.1` stuck on first...

@cenfun could you fix this to `v8-to-istanbul` as well?

Test passes with following: ```diff - import { onMount } from "svelte" + import { onMount } from "svelte/internal" ``` ``` RERUN src/lib/Hello.svelte x1 ✓ src/lib/__test__/Hello.test.ts (1) Test Files 1...