Ari Perkkiö

Results 126 comments of Ari Perkkiö

+1 for this. I really like the **idea** of using `c8`. Using native v8 coverage will definitely be fast since no code instrumentation is needed. But in practice it just...

> What is the difference between us configuring v8 and nyc? One is already configured but not correctly, it seems. I'm not expert here so please correct me if there's...

> [...] but I am not sure its possible to run c8 with browser? Exactly as @bjarkihall mentioned here, `c8` limits us to use Chromium/v8 based browsers. Chromium's Profiler is...

The coverage seems correct with the new `provider: 'istanbul'` option. Does this work for you @jerrythomas? C8: Istanbul:

It seems that `1.2.2` was published from a machine using CRLF line endings. Version `1.2.1` indeed works. PR #404 should prevent these in future. > ``` > $ grep version...

@MorisR nope, whole `--config-file` is still broken in latest `13.3.0` release. I've found another work-around which does not require creating root level cypress config as in https://github.com/cypress-io/cypress/issues/22689#issuecomment-1211732120. NPM adds `INIT_CWD`...

@kouts is this issue still valid? The reproduction case seems to work as expected: ``` ✓ test/async.test.ts (1) Test Files 1 passed (1) Tests 1 passed (1) Start at 14:30:29...

I think this and #3128 could share the mechanic of how test running is stopped. Maybe there should be a way to tell all pools (and their test runners) to...

> Try in the mac terminal. I'm able to reproduce this on Mac's terminal. However it works fine using VSCode's internal terminal and Warp. Here's minimal reproduction case which demonstrates...

What would this package actually do? As far as I know, `@storybook/builder-vite` was a separate package that was used to integrate Vite into Storybook. Nowadays it's no longer needed as...