Ari Perkkiö comments

Results 391 comments of


                                            Ari Perkkiö

fix(vitest): `vi.hoisted` syntax errors on instrumented code

This is getting quite complex. I think better and more maintainable solution is to: - Prevent `@vitest/coverage-istanbul` from instrumenting `vi.mock|hoisted|etc` method calls. This is done by adding `/* istanbul ignore...

fix(vitest): `vi.hoisted` syntax errors on instrumented code

https://github.com/vitest-dev/vitest/issues/6057#issuecomment-2813403136

perf(utils): optimize parse stack trace regexp

https://github.com/vitest-dev/vitest/pull/8531

Terminal UI flickering

Maybe this could help here? https://github.com/vitest-dev/vitest/issues/3732#issuecomment-2071861326

Source maps in inlined deps are off by a few lines in VS Code

Could you point out the incorrect source map? You can use [`vite-plugin-inspect`](https://github.com/antfu-collective/vite-plugin-inspect) or `VITE_NODE_DEBUG_DUMP=1 vitest` to capture the source maps. Note that `VITE_NODE_DEBUG_DUMP` adds a comment on top of the...

Source maps in inlined deps are off by a few lines in VS Code

@bgoscinski could you show in a recording how this should behave when running without Vitest? Use file like below with VSCode's debugger: ```js import { add } from "date-fns"; add(0,...

Source maps in inlined deps are off by a few lines in VS Code

Chrome Devtools with `vitest --inspect-brk` seems to work correctly even without the proposed fix of https://github.com/vitest-dev/vitest/issues/5605#issuecomment-2079507295.

Source maps in inlined deps are off by a few lines in VS Code

> Sure! Here's how it works without vitest/how it should work Using your reproduction in fresh Github Codespaces I'm unable to set breakpoints like shown in the video above. 🤷...

Source maps in inlined deps are off by a few lines in VS Code

> Yeah, in Github Codespaces I get the same result as you do... Could you try in "normal" vscode? I get the same results on local VSCode and Github Codespaces....

Source maps in inlined deps are off by a few lines in VS Code

Removing `columnOffset` from `vm.runInThisContext` seems to fix this: https://github.com/vitest-dev/vitest/blob/becabb5e38d0b347d1c2b71e996e3ceefb7e3e3c/packages/vite-node/src/client.ts#L419-L425 @sheremet-va that one is used for getting proper stack traces, right?