Ari Perkkiö

Results 391 comments of Ari Perkkiö

On `@vitest/coverage-istanbul` the root cause is here. We shouldn't remove the files from coverage object, instead reset all counters to `0`. https://github.com/vitest-dev/vitest/blob/8878b04dcef5d6bdcbb6a6874f944a8bc8d278e1/packages/coverage-istanbul/src/index.ts#L18-L20 On `@vitest/coverage-v8` there's something weird going on. I...

And `@vitest/coverage-v8` works fine with `isolate: false`, as long as `setupFiles` are not imporing the source files. You could try some work-arounds there in your project, if possible. Need to...

Branches are merged wrong here: https://github.com/vitest-dev/vitest/blob/3971ab7ea25142fef589723a42befa89a0cd18fe/packages/coverage-v8/src/provider.ts#L70 These reports ``` "ranges": [ { "startOffset": 200, "endOffset": 355, "count": 1 }, { "startOffset": 231, "endOffset": 273, "count": 0 } ], "ranges": [...

@RodrigoFerretti could you try if this preview release works correctly in your project? ```json { "devDependencies": { "@vitest/coverage-v8": "https://pkg.pr.new/@vitest/coverage-v8@6957", "vitest": "https://pkg.pr.new/vitest@6957" } } ``` https://github.com/vitest-dev/vitest/pull/6957#issuecomment-2495878654

Thanks for verifying the preview release @Mr-Guilherme and @RodrigoFerretti. Let's proceed with this fix in https://github.com/vitest-dev/vitest/pull/6957.

Configuring reporter options via CLI sounds good. > We use CLI to run tests in CI > `vitest --run --reporter=basic --reporter=github-actions` The `summary` of `default` reporter is disabled on CI....

@Daimon-EuDaimon just to be sure - this issue is about hiding `summary` in local environment only, even though you mention CI usage above? It's about having 100% same experience on...

Is this only on latest `2.2.0` beta releases?

Looks like this has been broken since `2.0.0-beta.13`. The `2.0.0-beta.12` and `1.6.0` work fine. - https://github.com/vitest-dev/vitest/pull/5926

If we could detect when these CORS errors happen, maybe we should show huge error modal on the UI?