Ari Perkkiö

Results 391 comments of Ari Perkkiö

We've had some discussions about this earlier with @Nemikolh. The way how learn.svelte does this is: - Add theme as query parameter in `iframe.src` https://github.com/sveltejs/learn.svelte.dev/blob/c1e1157f9f137fe63e2f9915a5453af1ccaad5ce/src/routes/tutorial/%5Bslug%5D/Output.svelte#L41-L52 - Read query parameter inside...

If this was implemented directly in V8, whole JS/Node ecosystem could benefit from this. Adding AST based coverage analysis is not ideal for performance.

A year later after my comment in https://github.com/nodejs/node/issues/54530#issuecomment-2322020403: For Vitest we went ahead and created a library for doing the AST analysis based V8 coverage conversion. For 2-3 years we...

This might be related to https://github.com/vitest-dev/vitest/pull/6968#discussion_r1862019482. If Vitest doesn't indicate `onFinish` to reporters when no files were run, most reports won't output anything.

@aimad-majdou could you try following and see if it fixes the issue for you: ``` npm i -D @vitejs/plugin-react ``` vite.config.ts: ```diff +import react from '@vitejs/plugin-react'; -import react from '@vitejs/plugin-react-swc';...

Here is minimal reproduction setup without Vitest: https://github.com/AriPerkkio/swc-istanbul-reproduction/blob/main/debug-swc-sourcemaps.mjs When `@swc/core`'s `jsx.transform.react.runtime` option is set to `'automatic'`, the file is marked as uncovered: ``` -----------|---------|----------|---------|---------|------------------- File | % Stmts | %...

@Alletkla unless you are using `@vitejs/plugin-react-swc` for that express application, you are likely not running into this issue. I would recommend to open new bug report with minimal reproduction. Once...

What's this @test-act-runner bot? It's not something I've set up. Looking at the CI runs, I don't think these are coming from this repository. Is some 3rd party sending these...

> If you add this code `process.on('SIGTERM', () => { process.exit(); })` to child process, it can dump the profile. Thanks for the work-around, this seems like good solution for...

Vite has a guide for these cases: https://vitejs.dev/guide/env-and-mode.html#production-replacement > For JavaScript strings, you can break the string up with a Unicode zero-width space, e.g. 'import.meta\u200b.env.MODE'. Instead of replacing the `process.env`...