Ari Perkkiö
Ari Perkkiö
@ericmorand yup, those lines cannot be covered so I would expect them to be excluded from report. This is similar how `nyc` and Jest (with default `babel` provider) works.
Looks like `node:test` started to exclude lines that are not present in source maps too: https://github.com/nodejs/node/pull/55228/files#diff-f93d30118ca2d349a10c8f93d740e1c988671a2e35ffe1213fedd6868df60e61R48
This sounds a bit similar as https://bugs.chromium.org/p/v8/issues/detail?id=10029. Though it doesn't make sense why this comes up only when Node version is upgraded. Maybe branches are counted differently based on the...
> but it seems to be working fine Great, thanks for checking this! 🙌 I'll check later if this issue is still valid. Feel free to proceed with the other...
> I'll check later if this issue is still valid. Yup, this is still valid. Added failing test case at https://github.com/stackblitz/tutorialkit/tree/test/terminal-false. Task assigned to @RonithManikonda. [tk-terminal-false.webm](https://github.com/user-attachments/assets/12bc1657-c2e1-4bf2-923e-5777021262e8)
@jamesg1 or anyone else, can you minimize the reproduction so it's easier to see what's causing this?
Do you mean you pushed changes that reduces the reproduction? I don't see any recent changes in https://github.com/jamesg1/example-vitest/commits/main/. The first thing any maintainer who wants to start fixing this issue...
What do you mean by not working? How is not working? What's expected and actual outputs? Per https://github.com/vitest-dev/vitest/issues/4731#issuecomment-1853405133 `isolate` on project level should not affect root/pool level isolation, meaning that...
Does this happen with `[email protected]` or just `1.5.0`?
Could you set up minimal reproduction for this? For example using https://node.new and running `npm create tutorial` there to get started?