tutorialkit
tutorialkit copied to clipboard
`Toggle Terminal` button should be hidden when `terminal: false`
Describe the bug
When terminal is disabled in metadata, the Toggle Terminal button is still visible. It just shows empty blank terminal when toggled.
Link to a StackBlitz project which shows the error
No response
Steps to reproduce
- Define in metadata:
---
type: lesson
title: Test
terminal: false
---
- Open page and click
Toggle Terminal
Expected behavior
Whole Toggle Terminal button should be hidden.
Screenshots
Platform
- TutorialKit version: 0.2.1
Additional context
No response
Hello @AriPerkkio. I was trying to recreate this issue but it seems to be working fine. Could you please help me out?
https://github.com/user-attachments/assets/924cf1a8-c0f2-4161-a268-cb8b4e9336e1
but it seems to be working fine
Great, thanks for checking this! 🙌
I'll check later if this issue is still valid. Feel free to proceed with the other issue mentioned in https://github.com/stackblitz/tutorialkit/pull/343#pullrequestreview-2322783870.
I'll check later if this issue is still valid.
Yup, this is still valid. Added failing test case at https://github.com/stackblitz/tutorialkit/tree/test/terminal-false.
Task assigned to @RonithManikonda.