ardupilot_wiki icon indicating copy to clipboard operation
ardupilot_wiki copied to clipboard

Update dependency 2024

Open khancyr opened this issue 1 year ago • 7 comments

update theme to 2.0.0. need https://github.com/ArduPilot/sphinx_rtd_theme/pull/22 -> this fix some small html and js errors -> allow to use python 3.11 and recent docutil to generate html update youtube plugin to latest version need https://github.com/ArduPilot/sphinxcontrib-youtube/pull/6 -> fix the status_iterator warning ->fix privacy video link -> don't generate thumbnails unless building for latex or pdf

raise docutil dependency to 0.20 raise sphinx version to 7.4.4

khancyr avatar Jul 16 '24 10:07 khancyr

lots of seemingly unrelated changes

Hwurzburg avatar Jul 16 '24 11:07 Hwurzburg

yes, it needs https://github.com/ArduPilot/ardupilot_wiki/pull/6118 first as we got some recursive dependences. Current Sphinx build don't catch it but the new version is catching it.

khancyr avatar Jul 16 '24 17:07 khancyr

most of the files changed in this PR bear no relation to the title or stated intention in its description...please separate into a different PR

Hwurzburg avatar Jul 16 '24 21:07 Hwurzburg

It needs the recursion fix PR otherwise it won't build and the two other PR. So this one should be the latest merged

khancyr avatar Jul 16 '24 22:07 khancyr

@khancyr I think maybe it would be good to remove the commit that is already included in #6118

rmackay9 avatar Jul 17 '24 00:07 rmackay9

@khancyr have you tested this thoroughly?

Hwurzburg avatar Jul 19 '24 16:07 Hwurzburg

I have build all wikis without issues reported. I have check manually that each a opening and open random pages : No visibles diff with the current version, images are at same place and video too. So that seems pretty safe.

For the build, it correct a bunch of issues and allow to build a bit faster this we can now disable some options that weren't used in our build !

Still need to be merged after the recursion , Youtube-contrib and theme update PRs, all three are needed to allow build with the new version.

khancyr avatar Aug 29 '24 17:08 khancyr