ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Rename HAL_PROBE_EXTERNAL_I2C_COMPASSES to AP_COMPASS_PROBING_ENABLED

Open peterbarker opened this issue 8 months ago • 3 comments

This is a no-compiler-output change.

This PR also force it to have a value, not just be defined.

pbarker@threads:~/rc/ardupilot$ ~/rc/ardupilot/Tools/scripts/filter_size_compare_branches_csv.py --hide-binary-identical /tmp/some.csv  
-----  ---------  -----  ----------  ------  ----  ----------  -----  -----  ---
Board  AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
-----  ---------  -----  ----------  ------  ----  ----------  -----  -----  ---
pbarker@threads:~/rc/ardupilot$ 

peterbarker avatar Jun 11 '25 22:06 peterbarker

(no compiler output change when hwdef changes are excluded from the binary, I should say!)

peterbarker avatar Jun 11 '25 23:06 peterbarker

Please can we delay on merging this. This makes all new boards defined in master not work in 4.6 and there are still a few boards in the works for 4.6, I think we should wait a couple more cycles before doing this.

Not repeating the same pain as the LED changes would be nice!

Could you evaluate ~~https://github.com/ArduPilot/ardupilot/compare/master...peterbarker:ardupilot:pr/catch-backport-problem?expand=1~~ https://github.com/ArduPilot/ardupilot/pull/30324 , please - as a patch to go back into 4.6 to avoid backporting errors.

peterbarker avatar Jun 12 '25 09:06 peterbarker

Not sure the other patch helps that much.

andyp1per avatar Jun 12 '25 16:06 andyp1per

I think the above would be nice but it's not mandatory. I added it to the list and configured all and there were no errors.

tpwrules avatar Oct 27 '25 19:10 tpwrules