ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Copter: announce number of completed circles in NAV_LOITER_TURNS

Open peterbarker opened this issue 9 months ago • 4 comments

image

Tested in SITL.

peterbarker avatar Jun 04 '25 01:06 peterbarker

I'm wondering whether the output is correct for this one. We announce how many we've completed, like we do for jumps. But perhaps this should be like waypoints instead where we announce which circle you're starting?

So it would be:

AP: Mission: 2 Starting circle 1/5

peterbarker avatar Jun 04 '25 23:06 peterbarker

thanks for this. I think that 2 floating out at the front should perhaps have something before it so that it's clear what it is (it's the mission command index I think)

rmackay9 avatar Jun 05 '25 01:06 rmackay9

thanks for this. I think that 2 floating out at the front should perhaps have something before it so that it's clear what it is (it's the mission command index I think)

It is - it lines up with the waypoint announcement which it follows. I'd be just as happy to remove it!

I would like feedback on whether we should do the "starting circle 2/5" thing rather than the current output which, when it says, "3/5" means you have just finished 3/5 circles. I think I really do prefer the first option.

peterbarker avatar Jun 06 '25 00:06 peterbarker

Hi @peterbarker,

you're probably right that we should specify when we've started rather than finish. In any case, I've approved

rmackay9 avatar Jun 06 '25 00:06 rmackay9

Adjusted this to announce which circle it is starting: image

peterbarker avatar Jun 06 '25 03:06 peterbarker

Relates to #25249 and friends.

nexton-winjeel avatar Jun 10 '25 23:06 nexton-winjeel