ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Tools: Upgrade tempcal_IMU.py

Open amilcarlucas opened this issue 10 months ago • 2 comments

Upgrade to python > 3.6 Added progress bar support Use logging best practices Lint with pylint, mypy, pyright and ruff Added type annotations Added pytests assertion tests

amilcarlucas avatar Mar 03 '25 15:03 amilcarlucas

@peterbarker can you take a look at the tests? I don't think we run pytest yet in CI do we?

amilcarlucas avatar Mar 04 '25 17:03 amilcarlucas

@amilcarlucas I'd like to see it being used with SITL, using SIM_IMUT parameters to setup a known temperature curve then checking the tool produces the same result both with and without the --online option it should be the plane.IMUTempCal test, check with that log that we get the same resulting calibration parameters, both with and without --offline

tridge avatar Mar 05 '25 07:03 tridge

@amilcarlucas tridge asked for some specific testing on this PR. Are you planning on doing that testing?

peterbarker avatar Jul 12 '25 01:07 peterbarker

@peterbarker do we have a pytest running CI job now? If not, I can do the tests that tridge wanted and add that.

amilcarlucas avatar Jul 14 '25 08:07 amilcarlucas

I will do this at the conference, with some help from tridge.

amilcarlucas avatar Jul 18 '25 09:07 amilcarlucas