ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

AP_DroneCAN: optimize message subscription process

Open tpwrules opened this issue 1 year ago • 2 comments

  • remove unnecessary nullptr check, these are always called from an initialized AP_DroneCAN so if it's nullptr something has gone horrifically wrong

  • pass in driver index instead of repeatedly calling function to get

  • simplify error handling; knowing exactly which allocation failed is not super helpful and one failing likely means subsequent ones will too, as it can only fail due to being out of memory

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            -636   *           -472    -472              -480   -472   -480
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      *
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  -240               -240    -232              -240   -232   -232
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-v2450                                         *                                       

tpwrules avatar Oct 14 '24 04:10 tpwrules

Tested that a DroneCAN GPS still works on CubeOrange.

tpwrules avatar Oct 14 '24 18:10 tpwrules

added DelayMerge for after 4.6 forks

tridge avatar Oct 15 '24 00:10 tridge