ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

AP_HAL_ChibiOS: add hwdef for LongBowF405WING

Open HiRCBro opened this issue 1 year ago • 13 comments

hi lefeirc PR new board with F405

HiRCBro avatar May 07 '24 14:05 HiRCBro

The commits should also be squashed

magicrub avatar May 07 '24 15:05 magicrub

@HiRCBro I've fixed up the commits in your PR

tridge avatar May 07 '24 19:05 tridge

In order to review I will need pinout/board image.....also, any UART intended for RC operation needs DMA so UART2 in alt configuration will not support CRSF/ELRS and perhaps even SRXL2 ptotocols....so those need to be on another UART...but no others have full DMA either...so RC protocols using bidir serial will have an issue with current definition I beleive

Hwurzburg avatar May 07 '24 22:05 Hwurzburg

the pinnout of each back side jst-gh connector is missing, labeled solder pads are clear, but what signals are in each JST-GH are not indicated on the back....

Hwurzburg avatar May 07 '24 23:05 Hwurzburg

In order to review I will need pinout/board image.....also, any UART intended for RC operation needs DMA so UART2 in alt configuration will not support CRSF/ELRS and perhaps even SRXL2 ptotocols....so those need to be on another UART...but no others have full DMA either...so RC protocols using bidir serial will have an issue with current definition I beleive

SBUS connect to UART2 with an inverter, if you use SBUS then UART2 cant work. if you use CRSF you cant connect to SBUS you need connect to UART2 or other UART

HiRCBro avatar May 08 '24 01:05 HiRCBro

UART2 and all other UARTs do not have full DMA required for CRSF/ELRS for sure...so you cant make those RC systems work reliably with this hwdef

Hwurzburg avatar May 08 '24 01:05 Hwurzburg

UART2 and all other UARTs do not have full DMA required for CRSF/ELRS for sure...so you cant make those RC systems work reliably with this hwdef


So i need change PA2 USART2_TX USART2 NODMA PA3 USART2_RX USART2 NODMA ALT(1) to: PA2 USART2_TX USART2 PA3 USART2_RX USART2ALT(1) ?

HiRCBro avatar May 08 '24 02:05 HiRCBro

unfortunately dma does not get assigned to alternate function pins....so that wont do it....I dont know of a way to do it on a uart whose primary pin function is RCINT for RC .....best to get one of the other UARTs DMA enabled....UART6 unfortunately was not assigned a DMA channel in the resolver....maybe @Tridge can make a suggestion, or you cna play with NODMA on some UARTS and see what the resolver produces for the others....you have to look at the hwdef.h file in the build directory after to waf configure for you board

Hwurzburg avatar May 08 '24 02:05 Hwurzburg

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

HiRCBro avatar May 08 '24 02:05 HiRCBro

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

if uart2 not suitbale for CRSF, we can use UART1, it is full DMA with RX and TX

HiRCBro avatar May 08 '24 12:05 HiRCBro

yes UART1 is the only one that can support CRSF/ELRS...so SBUS->RX2 s RCINT and all single wire RC, and UART1 can handle the two wire protocols

Hwurzburg avatar May 08 '24 12:05 Hwurzburg

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

its a matter of RELIABILITY.....CRSF and to a lesser extent ELRS will work without DMA, but not reliably...

Hwurzburg avatar May 09 '24 23:05 Hwurzburg

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

its a matter of RELIABILITY.....CRSF and to a lesser extent ELRS will work without DMA, but not reliably...

Understood, DMA can reduce CPU load and improve data processing capabilities

HiRCBro avatar May 10 '24 01:05 HiRCBro

se primary pin function is RCINT

i am confused, i test uart2 with CRSF is OK, do you mean, CRSF must work with a full DMA uart, i check hwdef.h only uart1 is full DMA with RX and TX.

its a matter of RELIABILITY.....CRSF and to a lesser extent ELRS will work without DMA, but not reliably...

HI When can this be merged into the master,thankyou.

HiRCBro avatar Jul 03 '24 01:07 HiRCBro

once the open review comments are addressed, the commits squashed and split into two commits one for Tools and one for hwdef it can be posted for devcall review and probable merge after that call.... if you wish, I can fix the readme recommended changes and squash and split commits for you....let me know

Hwurzburg avatar Jul 03 '24 01:07 Hwurzburg

once the open review comments are addressed, the commits squashed and split into two commits one for Tools and one for hwdef it can be posted for devcall review and probable merge after that call.... if you wish, I can fix the readme recommended changes and squash and split commits for you....let me know

Please help me complete it, thank you

HiRCBro avatar Jul 03 '24 01:07 HiRCBro

I have applied the changes, rebased, squashed, and library split....since I never got the board (delivered to wrong address I suppose) please retest the firmware on your board...once confirmed I will mark it for devcall (next one is Monday night GMT)

I have applied the changes, rebased, squashed, and library split....since I never got the board (delivered to wrong address I suppose) please retest the firmware on your board...once confirmed I will mark it for devcall (next one is Monday night GMT)

HI why LongBowF405WING still cant get from https://firmware.ardupilot.org/Plane/stable-4.5.7/

HiRCBro avatar Oct 15 '24 12:10 HiRCBro

because backports must be requested...I have marked for backport...but I am not sure it will be since 4.6 is about to beta release soon..

Hwurzburg avatar Oct 15 '24 12:10 Hwurzburg

because backports must be requested...I have marked for backport...but I am not sure it will be since 4.6 is about to beta release soon..

It's been 3 months since I submitted, please help to add it to 4.6?

HiRCBro avatar Oct 15 '24 12:10 HiRCBro

4.6 will be automatic...its backports that are not...but IF another 4.5 release occurs, it should be added now

Hwurzburg avatar Oct 15 '24 12:10 Hwurzburg

Ok. thank you

---- Replied Message ---- | From | Henry @.> | | Date | 10/15/2024 20:43 | | To | ArduPilot/ardupilot @.> | | Cc | HiRCBro @.>, Mention @.> | | Subject | Re: [ArduPilot/ardupilot] AP_HAL_ChibiOS: add hwdef for LongBowF405WING (PR #27009) |

4.6 will be automatic...its backports that are not...but IF another 4.5 release occurs, it should be added now

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

HiRCBro avatar Oct 15 '24 12:10 HiRCBro