ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Quadplane: fix Q_TRIM_PITCH description

Open robertlong13 opened this issue 1 year ago • 3 comments

The description refers to TRIM_PITCH, which was recently renamed to PTCH_TRIM_DEG.

robertlong13 avatar Feb 16 '24 19:02 robertlong13

I believe this is for the Q_TRIM_PITCH parameter, which is a different thing from the new PTCH_TRIM_DEG parameter which applies to a plane in fixed wing mode. This parameter was and is already in degrees. I agree it's confusing, but the Q_ parameter wasn't changed. How about changing the name of the parameter too?

timtuxworth avatar Feb 16 '24 20:02 timtuxworth

I believe this is for the Q_TRIM_PITCH parameter, which is a different thing from the new PTCH_TRIM_DEG parameter which applies to a plane in fixed wing mode. This parameter was and is already in degrees. I agree it's confusing, but the Q_ parameter wasn't changed. How about changing the name of the parameter too?

Yes, this is for the Q_TRIM_PITCH parameter, and it is different from PTCH_TRIM_DEG. But the part in the description that refers to "forward flight trim which includes TRIM_PITCH" is definitely referring to the old forward flight TRIM_PITCH parameter, not Q_TRIM_PITCH

I don't think we need to rename this parameter, we just need to fix the reference to the now-nonexistant parameter that it mentions in passing.

robertlong13 avatar Feb 16 '24 20:02 robertlong13

I see your point. That does actually clarify this then. Thanks Bob.

timtuxworth avatar Feb 16 '24 21:02 timtuxworth