ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

AP DDS Tests

Open SantamRC opened this issue 1 year ago • 6 comments

Adding Tests as per #25711

SantamRC avatar Jan 23 '24 09:01 SantamRC

Hi @SantamRC great work ! I have added a few suggestions for this. Please take a look. Thanks !!

arshPratap avatar Jan 23 '24 20:01 arshPratap

Thanks! Looks good, but seems the test is failing in CI. Any ideas? https://github.com/ArduPilot/ardupilot/actions/runs/7623561288/job/20763840428?pr=26069#step:13:8

Ryanf55 avatar Jan 23 '24 20:01 Ryanf55

No idea why the CI test is failing

arshPratap avatar Jan 24 '24 17:01 arshPratap

@arshPratap @Ryanf55 is there a map table to check which number corresponds to which mode? For the latest commit, it would be useful. Please review.

SantamRC avatar Jan 24 '24 17:01 SantamRC

@arshPratap @Ryanf55 is there a map table to check which number corresponds to which mode? For the latest commit, it would be useful. Please review.

Not that I've found unless we add a dependency on mavproxy: https://github.com/ArduPilot/MAVProxy/blob/c4619af111761135408476d6a7e79cea68cf8388/MAVProxy/modules/mavproxy_chat/assistant_setup/copter_flightmodes.txt

FOr now, just define them at the top of the test. I can figure out a better solution long term later. They are autopilot specific, and there doesn't seem to be a way to query the mappings at runtime. https://mavlink.io/en/messages/common.html#MAV_CMD_DO_SET_MODE

Ryanf55 avatar Jan 24 '24 17:01 Ryanf55

@arshPratap @Ryanf55 is there a map table to check which number corresponds to which mode? For the latest commit, it would be useful. Please review.

Not that I've found unless we add a dependency on mavproxy: https://github.com/ArduPilot/MAVProxy/blob/c4619af111761135408476d6a7e79cea68cf8388/MAVProxy/modules/mavproxy_chat/assistant_setup/copter_flightmodes.txt

FOr now, just define them at the top of the test. I can figure out a better solution long term later. They are autopilot specific, and there doesn't seem to be a way to query the mappings at runtime. https://mavlink.io/en/messages/common.html#MAV_CMD_DO_SET_MODE

Hi @SantamRC , you can follow it based on the links provided here

arshPratap avatar Jan 25 '24 05:01 arshPratap