ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

hwdef: Add AP_HW_JHEMCUGF16F405 board config

Open alex-pokydin opened this issue 2 years ago • 11 comments

Add support for hardware https://www.jhemcu.com/e_productshow/?76-JHEMCU-GF16-BMI-stack-F405-Flight-control-13A-ESC-76.html

alex-pokydin avatar Nov 23 '23 17:11 alex-pokydin

needs readme file with information like this one:https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/Readme.md

once created,I will review again

@Hwurzburg , done, please, review the PR, thanks!

alex-pokydin avatar Dec 12 '23 12:12 alex-pokydin

@Hwurzburg , thank you for your corrections. I do my best to fix/cleanup all points Please, check if all changes are correct Thank you!

alex-pokydin avatar Jan 26 '24 00:01 alex-pokydin

a few things were not addressed

@Hwurzburg , sorry again) I've just added VTX to hwdef and added your corrections to uarts please, check if it is ok now Thank you!

alex-pokydin avatar Jan 29 '24 14:01 alex-pokydin

looks good...you might want to contact AndyPiper and see if you can get BIDIR setup on at least the first four outputs...your choice

Thank you! BIDIR - it depends on ESC?

alex-pokydin avatar Jan 29 '24 14:01 alex-pokydin

yes....but a user may change from the bundled one or you may decide to upgrade the one you supply...if you dont include the capabiliiy, you cant have anyone migrate in the future without a firmware change...it has no downside to to include it...IF it can be done without removing DMAs from UART1 which you need for CRSF...your choice

Hwurzburg avatar Jan 29 '24 14:01 Hwurzburg

looks good...you might want to contact AndyPiper and see if you can get BIDIR setup on at least the first four outputs...your choice

@andyp1per , could you, please, help me with BIDIR ? How can I check it and set it up? Thank you!

alex-pokydin avatar Jan 29 '24 14:01 alex-pokydin

Hello @Hwurzburg , what should I do next to get the PR merged to master? Thanks

alex-pokydin avatar Feb 16 '24 11:02 alex-pokydin

@alex-pokydin I have again asked @andyp1per to look at this PR to suggest how to add bidir

Hwurzburg avatar Feb 16 '24 13:02 Hwurzburg

@Hwurzburg , lets keep it as it is for now and I'll add bidir in the next iteration if it is possible what do you think?

alex-pokydin avatar Feb 16 '24 16:02 alex-pokydin

your call I''l add a devcall label

Hwurzburg avatar Feb 17 '24 00:02 Hwurzburg

@alex-pokydin if you have trouble with the git commit fixups then I can do it for you ping me in code_review channel

tridge avatar Feb 19 '24 23:02 tridge

@alex-pokydin if you have trouble with the git commit fixups then I can do it for you ping me in code_review channel

Hello @tridge , fixed, please, check it thanks!

alex-pokydin avatar Mar 13 '24 10:03 alex-pokydin