hwdef: Add AP_HW_JHEMCUGF16F405 board config
Add support for hardware https://www.jhemcu.com/e_productshow/?76-JHEMCU-GF16-BMI-stack-F405-Flight-control-13A-ESC-76.html
needs readme file with information like this one:https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/SpeedyBeeF405WING/Readme.md
once created,I will review again
@Hwurzburg , done, please, review the PR, thanks!
@Hwurzburg , thank you for your corrections. I do my best to fix/cleanup all points Please, check if all changes are correct Thank you!
a few things were not addressed
@Hwurzburg , sorry again) I've just added VTX to hwdef and added your corrections to uarts please, check if it is ok now Thank you!
looks good...you might want to contact AndyPiper and see if you can get BIDIR setup on at least the first four outputs...your choice
Thank you! BIDIR - it depends on ESC?
yes....but a user may change from the bundled one or you may decide to upgrade the one you supply...if you dont include the capabiliiy, you cant have anyone migrate in the future without a firmware change...it has no downside to to include it...IF it can be done without removing DMAs from UART1 which you need for CRSF...your choice
looks good...you might want to contact AndyPiper and see if you can get BIDIR setup on at least the first four outputs...your choice
@andyp1per , could you, please, help me with BIDIR ? How can I check it and set it up? Thank you!
Hello @Hwurzburg , what should I do next to get the PR merged to master? Thanks
@alex-pokydin I have again asked @andyp1per to look at this PR to suggest how to add bidir
@Hwurzburg , lets keep it as it is for now and I'll add bidir in the next iteration if it is possible what do you think?
your call I''l add a devcall label
@alex-pokydin if you have trouble with the git commit fixups then I can do it for you ping me in code_review channel
@alex-pokydin if you have trouble with the git commit fixups then I can do it for you ping me in code_review channel
Hello @tridge , fixed, please, check it thanks!