ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

AHRS and EKF3: getting Active source set

Open shubham-shahh opened this issue 2 years ago • 2 comments

Hi, I noticed we have no bindings in Lua to find the active source set without an RC as demonstrated in other examples in Lua scripts. It will help in reducing the code used to infer the current source set from RC in the existing examples, this will be really helpful in autonomous source switching from GPS to SLAM to other sources autonomously based on some logic and in absence of RC

shubham-shahh avatar Aug 06 '22 15:08 shubham-shahh

Do all EKFs have to be using the same source set?

IamPete1 avatar Aug 08 '22 09:08 IamPete1

@IamPete1,

Yes, all cores use the same source set and only the EKF3 supports source sets.

rmackay9 avatar Aug 08 '22 10:08 rmackay9

@shubham-shahh,

Txs again for this. The code is looking fine now although I've requested a few formatting changes.

Could you also squash some of the commits together? In particular the "change the name of getter" commit.

rmackay9 avatar Aug 12 '22 00:08 rmackay9

@shubham-shahh,

Txs again for this. The code is looking fine now although I've requested a few formatting changes.

Could you also squash some of the commits together? In particular the "change the name of getter" commit.

Hi @rmackay9, thanks for the review, I have incorporated all the changes you mentioned above and tried cleaning the git commits, do let me know if there are any more changes. thanks again

shubham-shahh avatar Aug 12 '22 03:08 shubham-shahh

Hi, @rmackay9, are there any more changes to complete this PR? thanks

shubham-shahh avatar Aug 18 '22 04:08 shubham-shahh

Looking good, thanks!

rmackay9 avatar Aug 18 '22 06:08 rmackay9