ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Rover: add precision landing library to rover

Open shiv-tyagi opened this issue 3 years ago • 2 comments

This PR adds precision landing library to rover with minor changes to make the library work with the horizontal targets. Currently on rover, we only add the support for sending landing target information using a companion computer. The only modifications done in the precision landing library are related to rotation of target vector from camera frame to body frame (in camera frame z-axis point in the direction camera is facing). We do that with the help of PLND_ORIENT parameter in which we specify where is the camera mounted on vehicle's body. Currently, we add support for only down, front and back rotations, later we can add support for more orientations too. I have tested it's working with the new dock mode in rover. I'll be writing another PR to merge that mode too. This PR needs to be merged before that one. Thanks @rmackay9 and @peterbarker for all your guidance.

shiv-tyagi avatar Jul 06 '22 15:07 shiv-tyagi

How about moving the library to vehicle. We will want it on plane eventually probably. Maybe something to circle back to if you have time.

IamPete1 avatar Jul 06 '22 20:07 IamPete1

@IamPete1, yes, we discussed moving it to AP_Vehicle but push this off to a future PR because it would increase the scope of the change to involve fixing the definition as well (which is currently at the vehicle level).

rmackay9 avatar Jul 07 '22 00:07 rmackay9

check if any impact on flash size on plane

tridge avatar Aug 24 '22 07:08 tridge

Thanks @tridge for having a look on this one. Here is a screenshot from one of the CI tests which tells there is no effect of this on plane. The changes only affect rover majorly and copter a bit. Screenshot 2022-08-24 at 3 30 33 PM

shiv-tyagi avatar Aug 24 '22 10:08 shiv-tyagi

@rishabsingh3003 could you put your approval on this if you think it's OK? Thanks again for doing the detailed review!

rmackay9 avatar Aug 26 '22 02:08 rmackay9

Merged! hope this is OK with everyone. We need to keep moving forward so if there are any remaining concerns let's handle them in follow up PRs.

rmackay9 avatar Aug 30 '22 07:08 rmackay9