ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

RC_Channel: add RC_OPTIONS bit to clear RC override by RC input change

Open tatsuy opened this issue 3 years ago • 9 comments

This PR introduces a new option to clear the RC override, allowing the pilot to regain control by operating roll, pitch, throttle, or yaw during an RC override situation. While this functionality was previously possible using RCx_OPTION(46), the new option provides a more direct and safer method for pilots to cancel overrides using basic RC inputs.

The following settings are required RC_OPTIONS=16384 // it allows to clear overrides by Roll/Pitch/Throttle/Yaw RCx_OPTION=46 // (RC Override Enable) Re-enable RC overrides

I tested this on copter SITL.

tatsuy avatar Jan 21 '22 01:01 tatsuy

It is NG for the FC to not get permission from the CC. It is also not for the FC to take control of the CC without permission. When the FC cannot get a heartbeat from the CC, it is OK. If the CC is the primary, the FC is the limbs. When the CC is connected, the FC is a limb.

FC and CC should have a handshake procedure of "YOU HAVE" and "I HAVE".

PX4 has handshake in FC and MC. PX4 has an OFFBOARD mode. The ArduPilot needs to implement this OFFBOARD mode equivalent.

muramura avatar Jan 22 '22 06:01 muramura

@muramura In this PR, the AP's permission to clear Override can be set in RC_OPTIONS.

tatsuy avatar Jan 23 '22 04:01 tatsuy

Txs for this. In general I think it is good practice for the pilot holding an RC to be able to take control away from a companion computer easily. It makes sense to make it easy for a pilot to do that by simply moving the sticks.

rmackay9 avatar Feb 03 '22 03:02 rmackay9

@rmackay9 Thank you for your reviews. I've added a commit to make the changes easier to understand, but I'm going to squash it eventually.

tatsuy avatar Feb 03 '22 08:02 tatsuy

@rmackay9 I have used this with real rover. It works well and it's useful. Can you check this again?

tatsuy avatar Nov 08 '22 07:11 tatsuy

This sounds like a good idea to me.

@tatsuy did you want to rebase this?

peterbarker avatar Jul 25 '24 05:07 peterbarker

@peterbarker Thank you for your feedback. I have rebased.

tatsuy avatar Jul 30 '24 06:07 tatsuy

@peterbarker Thank you for the review. I have made the necessary changes based on your feedback. I also confirmed the changes through SITL testing. Could you please review the updates again?

tatsuy avatar Sep 24 '24 08:09 tatsuy

@peterbarker Thank you for the feedback! I rebased and fixed these.

tatsuy avatar Jun 05 '25 09:06 tatsuy

We tested this today on a quadcopter and it worked very well - exactly what we were expecting.

peterbarker avatar Jun 21 '25 09:06 peterbarker

I've put this on the EU dev call so we can review and possibly merge then

rmackay9 avatar Jun 23 '25 00:06 rmackay9