archived-PX4Firmware icon indicating copy to clipboard operation
archived-PX4Firmware copied to clipboard

Published 20 hours ago • verified publisher icon ArduPilot

oreoled merge

Open jschall opened this issue 9 years ago • 12 comments

jschall avatar Jan 07 '16 03:01 jschall

after merging this for a test build I found the fw shrank by 7.8k. I'm not complaining, I'm just surprised and suspicious. Any idea what make it a lot smaller?

tridge avatar Jan 07 '16 03:01 tridge

I think we also need to only start the oreoled driver on Solo. It is built and started unconditionally at the moment. I think we need a BRD_OREOLED parameter that starts the driver if needed (see how it was done for canbus in AP_BoardConfig) The reasons for making is only if the parm are set is to reduce the risk that these changes break non-solo. When I boot with these changes I see: oreoled on I2C bus 2 at 0x68 (bus: 100 KHz, max: 100 KHz) oreoled started OK on a naked pixhawk with no oreoled. That worries me. If the code only starts on solo then I know it is harmless. Solo can set it to start by default

tridge avatar Jan 07 '16 03:01 tridge

while adding BRD_OREOLED, maybe BRD_SMBUS would be a good idea too?

tridge avatar Jan 07 '16 04:01 tridge

We have a #define already (OREOLED_ENABLED) that we could use.

Ideally these drivers (SMBUS and OREOLED) would only be using resources if the relevant device was detected on startup.

jschall avatar Jan 07 '16 04:01 jschall

they use resources on all boards right now a parm in BRD_* would fix it nicely

tridge avatar Jan 07 '16 04:01 tridge

In earlier versions of the driver, I think it would shut itself down after 10seconds if it did not successfully communicate with the LEDs.

rmackay9 avatar Jan 07 '16 04:01 rmackay9

After discussing with Tridge, I'll add a BRD_ parameter for this.

jschall avatar Jan 07 '16 04:01 jschall

this is old and has conflicts. @jschall are you wanting to rebase this?

magicrub avatar Sep 26 '16 22:09 magicrub

Nope!

jschall avatar Sep 27 '16 00:09 jschall

looks like this is replaced with https://github.com/ArduPilot/ardupilot/pull/6092 so closing

magicrub avatar Apr 19 '17 22:04 magicrub

@magicrub They are completely different things. We don't have an oreoled driver in ArduPilot layer and, unless someone is doing it, it would be of interest to update the current one to the latest done by 3DR (not necessarily this PR).

OXINARF avatar Apr 19 '17 22:04 OXINARF

k, I'll reopen it and let it linger so someone can come along later and pick the branch to merge it some other time..

magicrub avatar Apr 19 '17 22:04 magicrub