archived-PX4Firmware
archived-PX4Firmware copied to clipboard
ArduPilot
Mavstation addition
Added support for mavstation board in MAVLink forwarding mode. --Uses PX4 Bootloader --Switches Radio UART to Raspberry Pi
Hi Kevin, I notice most of the files are listed as copyright either by Greg Nutt or the PX4 development team. If you based your work on theirs then giving them credit in the header (saying "based on XXX.c by Greg Nutt" for example) is common, but I think you should give your own copyright header unless you have some reason for assignment. Same for the "Author" tags. It is about blame really - if there is a bug then someone else reading the code should know who to ask about it, and not think that it is Greg who put the bug in. I'd also like Lorenz to have a look over these patches. I'll ping him and give him the URL for the pull request to have a look. Eventually these changes should be pushed back into upstream NuttX, and I'm not sure if Lorenz would prefer to do that himself (he talks to greg a lot) or if would prefer you to push them upstream. Cheers, Tridge
btw, thanks for breaking up the PR into nice logical commits. It is easy to follow. I'm very happy with the structure and approach you're taking, I just want to clean up the author and copyright notices and work out what the plan is for getting this upstream
Do you have an example of the crediting you are referring to? I'm used to closed source projects written from scratch so the copyright/Authorship for Open Source is still a bit new to me.
@kbrtny @Craig3DRobotics You will want to re-send this one against https://github.com/PX4/Firmware for feedback and integration. You also might want to consider to base this straight off recent NuttX @davids5 can help with the correct branches for that.
