MAVProxy icon indicating copy to clipboard operation
MAVProxy copied to clipboard

Option --no_param_auto_fetch to only fetch params on request. Preload added to menu.

Open crashmatt opened this issue 3 years ago • 3 comments

Command option --no_param_auto_fetch added to prevent parameters upload. Added console menu option for preload. This was necessary for testing.

Adding some state tracking to enable parameter fetch when requested while using this option.

Target is for use in bandwidth limited systems where parameter loading takes 5min+.

crashmatt avatar Oct 04 '21 20:10 crashmatt

Code style again! I suck at this.

Thanks for the review. /Matt

On Mon, 24 Jan 2022 at 00:35, Stephen Dade @.***> wrote:

@.**** commented on this pull request.

In MAVProxy/modules/mavproxy_param.py https://github.com/ArduPilot/MAVProxy/pull/939#discussion_r790347335:

                     if self.fetch_set is None:
                         self.fetch_set = set()
                     self.fetch_set.add(idx)
                     count += 1

Extra whitespace needs to be removed

— Reply to this email directly, view it on GitHub https://github.com/ArduPilot/MAVProxy/pull/939#pullrequestreview-860388311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVYHM64DNWD4VV7OK4QWLUXSGCZANCNFSM5FKHVWWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

crashmatt avatar Jan 25 '22 22:01 crashmatt

@crashmatt, are you able to fix up the whitespace issue? I'm keen to get this merged in :)

stephendade avatar Jan 29 '22 03:01 stephendade

I can do it but I have many other distractions right now. It is going to be a little while before I can get back to this project.

On Sat, 29 Jan 2022 at 04:47, Stephen Dade @.***> wrote:

@crashmatt https://github.com/crashmatt, are you able to fix up the whitespace issue? I'm keen to get this merged in :)

— Reply to this email directly, view it on GitHub https://github.com/ArduPilot/MAVProxy/pull/939#issuecomment-1024824869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVYHOSLOA6QJO3ONGVESTUYNPMXANCNFSM5FKHVWWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

crashmatt avatar Jan 31 '22 22:01 crashmatt