Mark Bakhit

Results 313 comments of Mark Bakhit
trafficstars

In the scenario where we auto-teardown, we've caught the error and can log the LOC. But in the scenario of user failure, it's a complete freeze with no user information....

I'm realizing sync effects can be generators too. Maybe we can stick with one `use_effect` but remove the ability to return a cancel function?

In terms of whether we diverge to creating `use_async_effect`, this issue is also relevant: https://github.com/reactive-python/reactpy/issues/1136 In my mind, threading should be unique to sync calls.

@rmorshea this PR contains the template tag itself, but not in a usable form due to - ~~Needing modification to websocket URL patterns (new pattern: `reactpy-ws-url/?`)~~ - Missing [JavaScript mount...

You think `reactpy-jinja` could be a good candidate to be contained in the monorepo? Maybe we should call it `reactpy-template-tag` to allow for future expansion? The decorator might be finnicky....

I think we really should push for the template tag being built-in to ReactPy. In my opinion, it should be our main way of advertising how to use ReactPy.

@rmorshea Is there a chance there's a better way of doing this? I'm not seeing anywhere within `preact`'s source code where they statically define event contents like this.

Yep, that's why this issue is marked as blocked for now.

@rmorshea In order to plan for easy compatibility between template tags and ASGI middleware, I'd like us to remove the hacky URL routing workaround from `reactpy/stream/`. As we discussed, that's...

Agreed that a formatted output would be nice. Am currently trying to programmatically use `pip index versions`, and it is slightly inconvenient to parse via regex.