Mark Bakhit
Mark Bakhit
If we shove `key` into the props dictionary `{"onClick": ..., "key"=...}` then this solution could move forward.
Hmm I thought there was a way to do it for the whole file. Worst case you could add that comment to each individual hook in the file.
Still not passing lint: `reactpy/core/hooks.py:504: error: Incompatible return value type (got "Sequence[Any] | EllipsisType | None", expected "Sequence[Any] | None") [return-value]**`** EDIT: Might be unrelated to your changes? If so,...
[WIP] Add connection resume, client state tracking, robust reconnect logic, reconnecting hooks, more
This is definitely way too much within one PR. Can you break this into smaller PRs?
[WIP] Add connection resume, client state tracking, robust reconnect logic, reconnecting hooks, more
Also just to re-iterate what I said over discord, I've only experienced WS disconnections under high load when ReactPy is not using a [`BACKHAUL_THREAD`](https://reactive-python.github.io/reactpy-django/latest/reference/settings/#reactpy_backhaul_thread). A potential alternative to client-side state...
@JaynouOliver We generally do not use the GitHub issue assignment feature. Priority is given to the first person to open a PR.
This is likely an issue with our our view that serves JavaScript modules. We need to make sure we're appropriately setting mime type headers within this view.
Will review on Monday. Not home at the moment.
Django has a similar timeout design for views. They have an arbitrary default of 20 seconds. ASGI webservers also have similar timeouts, specifically related to `keep-alive` requests. Usually default of...
On that note, maybe `teardown_timeout` is a more appropriate name.