Antoine Vandevenne (anv) comments

Results 106 comments of


                                            Antoine Vandevenne (anv)

Master new read group refactor tuple version ryv

@ryv-odoo Documentation PR? :pray:

[FIX] website_sale_delivery: disable checkout when COD it not with UPS

Hello @pivi-odoo, I saw that you flagged your PR as WIP so I'll unsubscribe for now. Please reset my request for review when you're ready ;) PS: Another way to...

[FIX] website_sale_delivery: disable checkout when COD it not with UPS

Hello @pivi-odoo, thanks for the changes :) While reviewing your PR, I investigated a bit more to figure out *why* this bug was even possible in the first place: This...

[FIX] website_sale_delivery: disable checkout when COD it not with UPS

~~Hello @pivi-odoo, did you close the PR by accident?~~ Nevermind; I read this notification before the enterprise one^^

[FIX] runbot: remove useless pip warning

:+1:

[IMP] sale,*: improve the sale onboarding flow

@robodoo override=ci/security Reason: Safe usage of markup in tour messages Link to ci/security build (master): https://runbot.odoo.com/runbot/build/62472415

[FIX] l10n_ec_website_sale: arguments method enforced in test

Hello :wave: Even if the test is adapted, I think you should merge this PR. Passing keyword arguments as positional arguments to `super` is not recommended and makes the code...

[IMP] tutorials/server_framework_101: rewrite the tutorial

Move actions back to their corresponding view's XML file.

[FIX] extensions: icon_role fa icons

Elisabeth is off at the moment and it's a change small enough to just move forward ;)

The link is broken and redirects to a 404 page from version 14 to version 17

Hi @otero-kreilabs, thanks for letting us know! :) @odoo/javascript-doc-review Could you check if the mentioned doc section still makes sense today?