documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[FIX] extensions: icon_role fa icons

Open samueljlieber opened this issue 1 year ago • 2 comments

Task: #3912370 [FIX] suggested from https://github.com/odoo/documentation/pull/9065#discussion_r1590702515

This PR fixes the FontAwesome icon_role implementation by automatically including the fa main class in the <i> class attribute when rendered. This was suggested to match the 16.0 Odoo UI oi implementation.

This PR should be merged after #9065.

samueljlieber avatar May 08 '24 14:05 samueljlieber

Hi @odoo/design-doc-review, just checking if you have any comments on this PR before I merge. Thank you!

samueljlieber avatar May 15 '24 17:05 samueljlieber

Elisabeth is off at the moment and it's a change small enough to just move forward ;)

AntoineVDV avatar May 16 '24 08:05 AntoineVDV

@robodoo r+

samueljlieber avatar May 16 '24 13:05 samueljlieber