Markus Gerstel

Results 41 comments of Markus Gerstel

Did we find out why this happened?

regarding crickets - declared opinions on the original comment https://github.com/cctbx/cctbx_project/issues/275#issue-395219936 are 2x positive, 0 otherwise - but there is no email notification for this.

no idea about toolchain, but I would advise running bootstrap with --verbose as this will give you the output, which may be more useful than "exit code 2"

I think the solution is to basically not replace any assignments unless the minimum supported version is 3.9: > This is why starting with Python 3.9, the following collections become...

The easier alternative is that you could just say the pre-commit hook is only supported for 3.9+ :slightly_smiling_face: I just saw that this hook is currently 3.8+ only, however my...

cctbx bootstrap runs fine (with Python 3.8+conda). DIALS bootstrap does not (with 3.8) I don't think I can be of more help here

Instructions to bootstrap DIALS on RHEL8. Start running in an empty directory, or in the directory above `modules/`. ```bash # Special sauce $ mkdir -p build/include modules/lib rheltemp && cd...

Leaving the ticket open though, because I believe this sort of stuff should work out of the box.

I think overall this sounds reasonable. I think an obvious suggestion at this point would be to move the `dials.stills_process` entrypoint into the `xfel` package. Also, just for information, the...