Markus Gerstel

Questionable whether defining multiple packages in a single `setup.py` as done here is even allowed. ``` $ pip install "git+https://github.com/cheshirekow/[email protected]" Collecting git+https://github.com/cheshirekow/[email protected] Cloning https://github.com/cheshirekow/cmake_format.git (to revision v0.6.13) to /tmp/pip-req-build-clga8wz3 ERROR:...

Although nobody commented on this I will change the approach here. There is a nicer way of achieving the same aim by introducing `DeprecationWarning`s first. This will make it easier...

My suspicion is that `PyString` is used where `PyBytes` should be used, and simply replacing the former with the latter may resolve the issue. Whether the function is called `as_bytes`...

I can see that being useful. However, could we please also have a way to programmatically determine the installed `cctbx_project` package version number? Ideally, this would be in a top...

How big are the files we are talking about? How well do they compress? Are they useful for other people? For example there is the option if they are not...

As discussed previously you absolutely don't want binary files in your development repository because as soon as they are in the history tree of a permanent branch they will stay...

Python 3.8 [no longer tolerates misuse of `is`/`is not`](https://bugs.python.org/issue34850) and throws this `SyntaxWarning`. cctbx does not officially support 3.8 yet. Feel free to submit a pull request

I like the idea of dials_dependencies as an intermediate stepping stone towards a true dials conda package. Minor nitpick: hdf5 is, as far as I am aware, not a _dials_...

[dials_dependencies now lives in conda-forge](https://anaconda.org/conda-forge/dials-dependencies) 👍

Probably all of these missing init files are "missing" on purpose. Not every directory is a python module. These paths are therefore deliberately not importable from python because they either...