Antares_Simulator

Antares_Simulator copied to clipboard

We should take care of remaining review remarks on closed PR #1219

guilpier-code

Number of rows in yearly time-series : 8760 or 8736 ?

2

Note * 8760=24*365 * 8736=24*364

flomnes

Show a diff of named MPS files in CI logs whenever there is a difference from the reference results

2

flomnes

Use `Simulation::ITimeSeriesNumbersWriter` for all modes (load, wind, solar, thermal, renewable, NTC)

2

See **src/solver/simulation/timeseries-numbers.cpp** Also, don't pass `time_series_writer` to function `StoreTimeSeriesNumbersIntoOuput` if possible (@JasonMarechal25 mentions dependency injection)

flomnes

`Application::onLogMessage` If an error occurs during the study load, the app exits (or not). This behavior is hidden from the developer. We need to de-couple error management & logging.

flomnes

flomnes

We should replace the use of plain enums with enum classes. Also, enum type should be used everywhere it's relevant instead of plain `int`, see methods such as: https://github.com/AntaresSimulatorTeam/Antares_Simulator/blob/96832a3a7f75534b5cb68ab7f62421a729acfb51/src/solver/variable/surveyresults/surveyresults.h#L86 **Edit**...

sylvlecl

flomnes

Add simulation.start and simulation.end in execution_info.ini

3

**Description** execution_info.ini file should contain simulation.start and simulation.end info (that are in generaldata.ini) as there are important to predict how long the study will take. It should belong to the...

MartinBelthle

See #669, #645 ``` *** No errors detected ==180016== ==180016== HEAP SUMMARY: ==180016== in use at exit: 14,325,551 bytes in 1,484 blocks ==180016== total heap usage: 415,668 allocs, 414,184 frees,...

flomnes