anslem chibuike

Results 11 comments of anslem chibuike

> Thanks for working out these functions `num` and `den` @AnslemHack . Your PR looks well taken care of! > > I made a few inline comments, can you have...

> A few more items: > > * `re()` and `im()` are in src/function/complex. Shouldn't these be in a new subdirectory src/function/fraction? (Jos?) > * Please add some tests showing...

Ran into this as well on Day.js 1.11.18 looks like .tz() reinterprets the input as local time, and then .toISOString() recalculates UTC based on the new offset. That causes unexpected...

looks like a bug in moment-webpack-plugin

@iamkun care looking at this fix? it addresses the wrong meridiem in arabic when time is 12pm

@devmashael1-prog what version of dayjs where you able to replicate this ?

@devmashael1-prog was able to replicate this, here's a simple fix https://github.com/iamkun/dayjs/pull/2952 now waiting for feedback from the maintainer

@dev-mashael-otb Good point I’ll review the other Arabic locale files and align the meridiem logic for consistency. Appreciate the heads-up!

@dev-mashael-otb I have now extended the fix to other arabic locales @iamkun care to look at this