Anorov
Anorov
Just to be clear, are you saying your issue with SSL wrapping is unrelated to the bug you found? My testing is not showing any issues with SSL sockets.
I agree this is confusing behavior, but I'm not sure there's a great way to fix it. `ssl.wrap_socket` returns a completely new `SSLSocket` object, with its own `connect` method. `socksocket`...
I will accept any pull requests for this.
Is it working okay with asyncio now?
Thanks for this PR. Could you please write a test for this, covering different kinds of addresses? We don't currently have any coverage for `getaddrinfo()`. And does this also prevent...
Ideally tests for both. Thanks.
>Do any of the existing tests actually check for leaks outside of the proxy? Not currently. >if you like I can just publish the code for the leak detector and...
Thanks. Would you be willing to submit a pull request?
I posted a comment regarding all of this in the relevant requests-ntlm issue: https://github.com/requests/requests-ntlm/issues/20#issuecomment-24014600 Basically, I think all of this (NTLM server auth as well as NTLM proxy auth) should...
@sigmavirus24 > Frankly I'd like to see NTLM auth removed from urllib3 and see requests-ntlm deprecated permanently. What is your suggested alternative, then? Adding native support to urllib3 or requests,...