PyWhatKit icon indicating copy to clipboard operation
PyWhatKit copied to clipboard

Dowload files support

Open biegehydra opened this issue 1 year ago • 4 comments

Additions

  • Two additional configurations
    • allowDownloadAll - Permits users to zip an entire folder (non recursive) and download it
    • allowDownload - Permits users to download individual files
  • 1 additional dependency
    • For zipping files I used JSZip

DownloadAll

biegehydra avatar May 26 '23 17:05 biegehydra

@qoomon Anything need fixed for this to be brought in?

biegehydra avatar Aug 01 '23 03:08 biegehydra

sorry for the late response, I'll try to review it this weekend

qoomon avatar Aug 04 '23 07:08 qoomon

Hi, thanks for the PR. Some opinion brainstorming:

  • I don't think we need the option allowDownload
  • We need to have a progress bar for file downloading status
  • Mabe Download Allshould download really all files including paginated files
  • Maybe we should add checkboxes to mark which files we want to download
  • We should add a dialogue to ensure someone really wants to download X files with a size of Y
  • What about an option to download all files including subdirectories?
  • What about a file count or size limit?

WDYT?

qoomon avatar Aug 07 '23 08:08 qoomon

  • I don't think we need the option allowDownload
  • We need to have a progress bar for file downloading status
  • Mabe Download Allshould download really all files including paginated files
  • Maybe we should add checkboxes to mark which files we want to download
  • We should add a dialogue to ensure someone really wants to download X files with a size of Y
  • What about an option to download all files including subdirectories?
  • What about a file count or size limit?

WDYT?

I think they're all good ideas. I'm not that familiar with Vue or Buefy so adding all these features will be difficult for me. I'll take a wack at it when I get the chance though.

biegehydra avatar Aug 18 '23 04:08 biegehydra

@qoomon can we update this PR and merge? Really useful for my use cases when people want download folder or all files in folder instead of walking 1000+ files

Illia-M avatar Aug 05 '24 16:08 Illia-M

@Illia-M Latest version (3.1.0) does support download all files from current page.

@biegehydra thanks a lot for this PR

qoomon avatar Aug 07 '24 06:08 qoomon