Aniket
Aniket
> Also, it is currently assumed **without checking** that the extra array-likes needed for cov types have exactly the same rows as the original exog/endog arrays. > > Specifically, if...
Hi @jbrockmendel I think i might be a bit lost here. Could you please guide me if i’m heading in the wrong direction? Thank you!
@jbrockmendel Thanks for the review and the corrections. Only one test failure is left now. `FAILED pandas/tests/arrays/test_datetimes.py::test_dt64_non_nano_offset_no_rounding - AttributeError: 'datetime.datetime' object has no attribute 'tz_localize'`
I’m a bit confused about this assertion error, it shows up in ci, but I’m unable to reproduce it locally. ``` 0.01s call pandas/tests/arrays/test_datetimes.py::TestDatetimeArray::test_iter_zoneinfo_fold[pytz/US/Eastern] 0.01s call pandas/tests/arrays/test_datetimes.py::test_dt64_non_nano_offset_no_rounding ============================ 2474 passed...
@jbrockmendel Could you please take a look in this, If i'm not in wrong direction.
@jbrockmendel Please review these changes, whenever you get a chance.
@jbrockmendel I've updated the code as per your suggestion. Please let me know if this also needs a whatsnew entry.
@jbrockmendel Is this PR ready now? The two ci-failures seem to be expected, since they’re caused by these. `@pytest.mark.xfail(reason="copy keyword is missing")` `@pytest.mark.xfail(reason="copy=False is not Implemented")` please let me know...
@rgommers When you get a chance, could you please take a look at this? I’ve made the small changes that should address the issue, please let me know if I’m...
@rgommers Thanks for pointing this out, apologies for not including the detailed description earlier. I’ve updated the description. I’ll make sure to include such details in all future PRs. please...