Aniket
Aniket
@ankurankan Thanks for pointing it out. I made some changes using an llm, and while testing locally I ran into two failing tests. I think those changes were unnecessary. I’ll...
@ankurankan I was planning to do in weekend, this was not ready, and i apologize I thought this was in draft, and I was removing changes which I had done...
Also i would like to apologize for creating extra work and causing any inconvenience.
@ankurankan I've reverted the unnecessary changes I introduced earlier and spent some time reviewing the implementation again. I would also like to understand the algorithm in more depth in any...
> I think the logic in Step 3.1 of the algorithm will need to be modified, as it currently fixes all CPDs that do not involve latent variables. However, with...
@ankurankan sure, I will fix this .
``` C:\Users\Aniket.DESKTOP-074O80J\pgmpy\pgmpy>pre-commit run check yaml...........................................(no files to check)Skipped fix end of files.........................................................Passed trim trailing whitespace.................................................Passed isort....................................................................Passed black....................................................................Passed flake8...................................................................Passed blackdoc.................................................................Passed ``` @ankurankan I'm still seeing a linting error on this. ```...
@ankurankan sure, I’ll wait for the API clarification before making further changes.
Please let me know if I need to make any further changes or if there are any updates regarding this.
@ankurankan Thanks for the explanation, I’ll look into this as well and share my thoughts if I find something useful.