Godot-DialogPlugin icon indicating copy to clipboard operation
Godot-DialogPlugin copied to clipboard

Add Visual Novel Example to Example branch

Open Crystalwarrior opened this issue 3 years ago • 6 comments

Add a visual novel example, including a test timeline showing off blips, background transitions, etc

https://user-images.githubusercontent.com/3470436/148605301-f13dba30-a7c8-411a-b9ea-0696e6005cc8.mp4

.

Crystalwarrior avatar Dec 31 '21 12:12 Crystalwarrior

I think it needs more comments to know what you were doing (I can understand what is happening here, but since we're on the examples branch, we need to do it with ELI5 as possible)

I agree. I will excessively comment it once I have the code as modular and nice to read as possible

Crystalwarrior avatar Jan 04 '22 18:01 Crystalwarrior

Gonna merge this branch after you change the "text text text" placeholder with a proper one (like "placeholder text" or just ""). The other two revisions can be made in a different branch

AnidemDex avatar Jan 04 '22 18:01 AnidemDex

A few points:

* Restore `.gdignore` file

* Are `psd`, `xcf`, `lnk` files necessary?

.psd, .xcf, etc. files are not really necessary, they could be distributed separately. Source files can be helpful for creators to understand how the sprites are composed tho.

Crystalwarrior avatar Jan 06 '22 13:01 Crystalwarrior

don't forget to rebase main and force push your branch when you're done to solve merge conflicts

AnidemDex avatar Jan 06 '22 19:01 AnidemDex

Worked on my game, gotta backport a lot of new discoveries I made during its development into this example later

Crystalwarrior avatar Jan 21 '22 21:01 Crystalwarrior

Please, mark it as done when you think is ready to be merged.

AnidemDex avatar Jan 24 '22 15:01 AnidemDex