Angel Ezquerra

Results 9 comments of Angel Ezquerra

> New modules should be put at `std/` directory so that it enforces std prefix when importing them. I've moded batteries.nim (but not prelude) to std.

> Sorry that I'm changing my mind more frequently than my underwear about this but what is exactly the problem again? That you cannot remember `include prelude`? How couldn't you?...

Many of the items that were missing are now available: svd, pinv (i.e. pseudo-inverse), product along an axis, mclamp, eye (and several related functions such as identity and diag) and...

I guess that makes sense if that is the case, but then I think that some way to see the whole commit graph is necessary. Otherwise you need to revert...

> `sub2ind` is essentially `getIndex` https://github.com/mratsim/Arraymancer/blob/master/src/arraymancer/tensor/private/p_accessors.nim#L60, no? (just with `seq` input) > > Maybe we can reuse the internal logic? In general `sub2ind` and `ind2sub` seem very Matlab focused concepts...

> > `sub2ind` is essentially `getIndex` https://github.com/mratsim/Arraymancer/blob/master/src/arraymancer/tensor/private/p_accessors.nim#L60, no? (just with `seq` input) > > Maybe we can reuse the internal logic? In general `sub2ind` and `ind2sub` seem very Matlab focused...

I just pushed a fix to the original (non gemm) version which solves a problem with convolving a slice (was using `unsafe_raw_data` where I should have used `unsafe_raw_offset`). The change...

> It looks fine to me now. One could clarify a bit more in the docstrings how different ranks are handled and specify that the mask and fill value tensors...

> It looks fine to me now. One could clarify a bit more in the docstrings how different ranks are handled and specify that the mask and fill value tensors...