Andreas Allacher

Will have to test this but I once I am on the workstation where I have set this up. Possibly tomorrow.

Actually it mostly works already. Sylius by default uses province code, if the country has provinces and that seems mostly fine with the Shop API. **HOWEVER:** The `\Sylius\ShopApiPlugin\Factory\AddressBook\AddressViewFactory` only serilizes...

Another reason why this isn't a good ideas: - A customer gets reduced prices - Now, someone else knows that customer's e-mail address and does a guest checkout with their...

I can't think of all the needed scenarios but one thing I would expect: - User A is logged int - User A has a cart with various items in...

In general you need various improvements regarding this as e.g. shipping charges by default include the tax in Sylius (always). However, the tax total also includes the tax of the...

I also think it is a bit confusing how Sylius itself handles it in their entities. Having one method that returns the value with and one without taxes would make...

Not perfect but a first temporary solution would be to allow non-set values in: https://github.com/Sylius/ShopApiPlugin/blob/master/src/Model/Address.php#L66 and use `?? null` when setting the properties. Probably not perfect but at least the...

I thought the model in between you use for the ShopPluginApi instead of the Entity is to pre-parse the data and use it for validation? If you expect it to...

You could also add a validation for the array data. It would probably be the fastest workaround. Not that nice but it should work, see documentation: https://symfony.com/doc/4.4/reference/constraints/Collection.html