ShopApiPlugin icon indicating copy to clipboard operation
ShopApiPlugin copied to clipboard

Published 20 hours ago • verified publisher icon Sylius

[FEATURE] Support for subTotal - added in Sylius 1.6

Open AndreasA opened this issue 5 years ago • 3 comments

With Sylius 1.6 they added better support regarding taxes and subtotal. The itemsTotal always includes taxes. Now the summary contains the items total (with tax) - if strategy is set accordingly - or without tax the sub total. This was added with https://github.com/Sylius/Sylius/pull/10400/files

AndreasA avatar Nov 06 '19 07:11 AndreasA

In general you need various improvements regarding this as e.g. shipping charges by default include the tax in Sylius (always). However, the tax total also includes the tax of the shipping charges, so any subtotal one might calculate manually will always be wrong.

AndreasA avatar Nov 06 '19 09:11 AndreasA

Yes, that is true. The totals object is quite confusing.

mamazu avatar Nov 06 '19 12:11 mamazu

I also think it is a bit confusing how Sylius itself handles it in their entities. Having one method that returns the value with and one without taxes would make it way easier to get the desired values for the webshop.

AndreasA avatar Nov 12 '19 05:11 AndreasA