Anderson Queiroz

Results 43 comments of Anderson Queiroz

There is also the memory usage for 1kb per file in memory. It can be addressed by using a hash, it just makes the "prefix" comparison more expensive as it's...

just for the record. I'm working on a POC for a growing fingerprint. Which I believe is the most delicate part, integrate a growing fingerprint on filestream. With that we...

I put up the POC I did: - https://github.com/elastic/beats/pull/48025 I think the most interesting part are [the tests](https://github.com/elastic/beats/pull/48025/files#diff-f5a6ab16beb5a3de221509cce17b06e60b3ae56107c3b233ebc7a9f36da4eb6aR1) so you can see what works. The CI still needs to run...

@khushijain21 is it really ready for review?

@khushijain21 it seems some of the tests still need updating: ``` DONE 2 tests, 1 skipped in 1.194s >> go test: Integration-rabbitmq/shovel Test Passed >> go test: Integration-redis Testing exec:...

> Is there a way to avoid the disruptive user behavior by separating gzip support in: > > 1. enabled -- return error for file identities other than fingerprint >...

> So the smartest thing to do is only log about potential data duplication if we actually try to ingest a .gzip file and direct people to either switch to...

@cmacknz I updated it as you requested @orestisfl, @colleenmcginnis when you have time, could you please re-review?

> I got some feedback from PM (Bill) that we may not want to have this be enabled by default just to minimize any chance of user disruption. ok, makes...

@orestisfl, @cmacknz it's ready for review :)