beats icon indicating copy to clipboard operation
beats copied to clipboard

[beatreceiver] Remove global paths from auditbeat

Open khushijain21 opened this issue 3 weeks ago • 8 comments

Proposed commit message

This PR removes global instance of paths from auditbeat package

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

None

Related issues

  • Closes https://github.com/elastic/beats/issues/46992

khushijain21 avatar Dec 05 '25 10:12 khushijain21

:robot: GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

github-actions[bot] avatar Dec 05 '25 10:12 github-actions[bot]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @khushijain21? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

mergify[bot] avatar Dec 05 '25 10:12 mergify[bot]

This pull request doesn't have a Team:<team> label.

botelastic[bot] avatar Dec 05 '25 10:12 botelastic[bot]

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

elasticmachine avatar Dec 05 '25 11:12 elasticmachine

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

elasticmachine avatar Dec 05 '25 11:12 elasticmachine

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

elasticmachine avatar Dec 05 '25 11:12 elasticmachine

@khushijain21 is it really ready for review?

AndersonQ avatar Dec 10 '25 09:12 AndersonQ

@khushijain21 is it really ready for review?

Khushi is on PTO this week, so I think it's safe to move it back to draft until next week.

mauri870 avatar Dec 10 '25 11:12 mauri870

@khushijain21 it seems some of the tests still need updating:


DONE 2 tests, 1 skipped in 1.194s
>> go test: Integration-rabbitmq/shovel Test Passed
>> go test: Integration-redis Testing
exec: gotestsum --no-color -f standard-quiet --junitfile build/TEST-go-integration-redis.xml --jsonfile build/TEST-go-integration-redis.out.json -- -tags=integration -covermode=atomic -coverprofile=build/TEST-go-integration-redis.cov -timeout=2h ./module/redis
# github.com/elastic/beats/v7/metricbeat/module/redis [github.com/elastic/beats/v7/metricbeat/module/redis.test]
module/redis/metricset_integration_test.go:136:50: not enough arguments in call to mb.NewModule
	have (*config.C, *mb.Register, *logp.Logger)
	want (*config.C, *mb.Register, *paths.Path, *logp.Logger)
FAIL	github.com/elastic/beats/v7/metricbeat/module/redis [build failed]

AndersonQ avatar Dec 17 '25 12:12 AndersonQ

@nfritts / @lalit-satapathy / @zmoog could we get your approval here please?

pierrehilbert avatar Dec 22 '25 13:12 pierrehilbert

@khushijain21 Doesn't PR title needs tweaking? Is this better?

Add paths parameter to metricbeat module framework for auditbeat

shmsr avatar Dec 23 '25 10:12 shmsr