Anchels comments

Repositories
Issues
Comments

Results 2 comments of


                                            Anchels

Fix inconsistency found by static analyzers

Similar issues, but with `ngx_palloc` function: `shm_name` is dereferenced without checking for null: https://github.com/samizdatco/nginx-http-auth-digest/blob/5a2cae4812d8a1ba5f83dfbcb8d043d05c8e6f97/ngx_http_auth_digest_module.c#L75-L76 same for `*d`: https://github.com/samizdatco/nginx-http-auth-digest/blob/5a2cae4812d8a1ba5f83dfbcb8d043d05c8e6f97/ngx_http_auth_digest_module.c#L499-L517

Code Inconsistencies Detected by Static Analysis

@splitice, thank you for the feedback! > I think 2 is fine due to r->main not being NULL. Do you mean that in this case `r` will never be NULL?...