Alberto M Valdunciel

Results 13 comments of Alberto M Valdunciel

Hi, @mooreniemi . I ran into this same issue, and it looked like the cause was not that the files were missing, but that the gem was not taking the...

On the second point about the problem the rendering changed what I wrote. I meant: > "-- $@" and "-- $\"$@\""

Thank you for the quick response! I forked the package and ran into a couple of issues: 1. There is a clash while defining `JSON` as a type, as the...

Additionally, this method can probably be simplified from: ````julia function parse(::Type{MergedJSON}, buf::IOBuffer)::Vector{Pair{String,Any}} nt = JSON.parse(buf) return [Pair(string(k),v) for (k,v) in pairs(nt)] end ```` `nt` should now be a dictionary, by...

The issue with that is that the wrong behaviour is still present in `JSON3`. I will open an issue in that repository. It was an open issue on the older...

Ok, so I took another look and it was very easy to preserve your external API (so no external changes needed). I got all tests passing except for two: ```julia...

After reading the documentation, this solves the issue: ```julia buf = IOBuffer("3") JSON.parse(read(buf, String)) ``` I made a PR. Thank you for your time and quick responses. Let me know...

I am not sure I understand what do you mean with the last message.

Ah, I see. So is there something else I should do for the Pull Request to be accepted? :)

Alright. I incorporated the changes and now all checks are passing. Thank you for the support.