Results 179 comments of Louis Gesbert
trafficstars

I'd prefer it not to be squashed as this loses a lot of information. In particular, if one wanted a build working with 4.14, it can easily be extracted now...

Thanks a lot for reviewing, this last patch should address your concerns :)

This has been long enough, I think this should be merged even with the failure which is limited to the macos scripts; Unless there are comments within the next days...

Thanks @erikmd, for the last review and fixes ! Indeed that zstd linking issue warranted digging deeper than I'd have expected 😅 About 4., I think so, but without certainty......

Rebased and removed the pin-depends ; note that ocp-indent-nlfork is still pending publication (https://github.com/ocaml/opam-repository/pull/27305) so CI is expected to fail until then

Thanks a lot! > would you be OK that we open a side issue, just to remember checking this later? (even if I'm not worried at all about this: I...

Added sister branch in catala-examples (to remove the flag that this made obsolete). Don't forget to merge both in sync!

Fixed one last closure conversion bug, this should be good to go except for the actual implementation of `handle_exceptions` in R

Ah, note that, while everything else is working correctly, I had trouble when trying to display a completion widget: ``` Error while loading the completion UI: The resource at '/org/gnome/gtksourceview/ui/gtksourcecompletion.ui'...

Status update: - `foo.1`, `foo.2` etc. is now supported - the syntax `let (x, y) = z` is still supported and should probably be removed - no pattern-matching yet